Skip to content

encode newPassword *properly* in the password reset form #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

penguinite
Copy link
Contributor

@penguinite penguinite commented Apr 19, 2025

This commit fixes #374 by calling encodeUrl from std/uri on the password before sending the request. In my own testing, I was able to use pretty much every problematic character from the issue report, but I think this should be tested more by different people. (I can't believe it was this simple to fix, surely there's a catch...)

This fix is not the most ideal one, it would be best if someone re-wrote the code to submit the new password using multipart, I tried writing this fix but I got mysterious errors and gave up.

@penguinite
Copy link
Contributor Author

"(stable, stable)" fails due to it not being able to load libpcre.so
"(stable, devel)" fails for some mysterious reason (package management issues?)

@PMunch
Copy link
Collaborator

PMunch commented Apr 24, 2025

This is great, sometimes bugs are easy to fix just because no-one has tried yet :) In any case this is better than the current code so I'd say it's good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passwords do NOT support "#"
3 participants