-
Notifications
You must be signed in to change notification settings - Fork 23
[#610] [Part 2] Update navigation library and refactor template to expose event callback to navigate #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: chore/610-part-1-update-navigation-library-and-refactor-to-follow-unidirectional-data-flow
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -9,12 +9,12 @@ accompanist = "0.30.1" | |||
chucker = "4.0.0" | |||
composeBom = "2025.02.00" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newer version of androidx.compose:compose-bom than 2025.02.00 is available: 2025.04.01 |
@@ -9,12 +9,12 @@ accompanist = "0.30.1" | |||
chucker = "4.0.0" | |||
composeBom = "2025.02.00" | |||
# @kaungkhantsoe Will update in a separate PR | |||
composeNavigation = "2.5.3" | |||
composeNavigation = "2.8.9" | |||
core = "1.15.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newer version of androidx.core:core-ktx than 1.15.0 is available: 1.16.0 |
@@ -9,12 +9,12 @@ accompanist = "0.30.1" | |||
chucker = "4.0.0" | |||
composeBom = "2025.02.00" | |||
# @kaungkhantsoe Will update in a separate PR | |||
composeNavigation = "2.5.3" | |||
composeNavigation = "2.8.9" | |||
core = "1.15.0" | |||
datastore = "1.1.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newer version of androidx.datastore:datastore-preferences than 1.1.2 is available: 1.1.5 |
@@ -9,12 +9,12 @@ accompanist = "0.30.1" | |||
chucker = "4.0.0" | |||
composeBom = "2025.02.00" | |||
# @kaungkhantsoe Will update in a separate PR | |||
composeNavigation = "2.5.3" | |||
composeNavigation = "2.8.9" | |||
core = "1.15.0" | |||
datastore = "1.1.2" | |||
detekt = "1.21.0" | |||
gradle = "8.8.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newer version of com.android.application than 8.8.1 is available: 8.9.2. (There is also a newer version of 8.8.𝑥 available, if upgrading to 8.9.2 is difficult: 8.8.2) |
@@ -9,12 +9,12 @@ accompanist = "0.30.1" | |||
chucker = "4.0.0" | |||
composeBom = "2025.02.00" | |||
# @kaungkhantsoe Will update in a separate PR | |||
composeNavigation = "2.5.3" | |||
composeNavigation = "2.8.9" | |||
core = "1.15.0" | |||
datastore = "1.1.2" | |||
detekt = "1.21.0" | |||
gradle = "8.8.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newer version of com.android.library than 8.8.1 is available: 8.9.2. (There is also a newer version of 8.8.𝑥 available, if upgrading to 8.9.2 is difficult: 8.8.2) |
Kover report for template-compose:🧛 Template - Compose Unit Tests Code Coverage:
|
File | Coverage |
---|---|
AppDestination.kt |
75.00% |
AppNavGraph.kt |
75.44% |
BaseAppDestination.kt |
53.85% |
BaseViewModel.kt |
69.57% |
HomeScreen.kt |
70.47% |
MainDestination.kt |
60.00% |
MainNavGraph.kt |
100.00% |
NavHostControllerExt.kt |
0.00% |
NavigationExt.kt |
48.72% |
Modified Files Not Found In Coverage Report:
HomeScreenTest.kt
libs.versions.toml
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
d220269
to
b3efc02
Compare
5f0d06b
to
937dc67
Compare
b3efc02
to
b651f17
Compare
…irectional data flow for template compose
937dc67
to
3811dfe
Compare
#610
What happened 👀
Insight 📝
N/A
Proof Of Work 📹
CI should pass for all tests