Replace the cancel previous run by the concurrency #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,17 +15,16 @@ env: | |||
| HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }} | |||
| HEROKU_APP_NAME: ${{ secrets.HEROKU_APP_NAME }} | |||
|
|
|||
| concurrency: | |||
| group: ${{ github.workflow }}-${{ github.ref }} | |||
| cancel-in-progress: ${{ github.ref != 'refs/heads/main' }} | |||
There was a problem hiding this comment.
shall we cancel it on the develop branch as well 🤔 because we deploy to Staging from the develop
byhbt
force-pushed
the
chore/remove-cancel-previous-run
branch
from
4ccb1bb to
6b15723
Compare
olivierobert
reviewed
Aug 1, 2023
There was a problem hiding this comment.
@byhbt let's complete this PR as there is not much left to do, no?
yup, i was checking about the Andy suggestion 😅 , let me update it and make it ready for review today or tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
Cancel Previous Runsin all the workflow. Replace it by theconcurrencygroupInsight 📝
As the suggestion from the creator of
Cancel Previous Runs:Reference: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency
Proof Of Work 📹