Fix DHT GetRecord query wedge on untrusted peer responses#3716
Merged
Fix DHT GetRecord query wedge on untrusted peer responses#3716
Conversation
viquezclaudio
approved these changes
Apr 22, 2026
a7bf076 to
01cc6db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An untrusted peer could respond to a DHT
GetRecordquery in ways that left the query in an inconsistent state, preventing it from ever completing and wedging the requester.This change:
DhtGetInconsistentState,DhtGetVerificationFailed, andDhtGetTimeouterror variants.abort_dht_get()which finishes the query, clears intermediate state, and surfaces the failure to the waiting channel.Pull request checklist
clippyandrustfmtwarnings.