Skip to content

Enable raw bytes data output for edge cases#191

Open
Arno500 wants to merge 6 commits into
nimiq:masterfrom
criteo-forks:master
Open

Enable raw bytes data output for edge cases#191
Arno500 wants to merge 6 commits into
nimiq:masterfrom
criteo-forks:master

Conversation

@Arno500

@Arno500 Arno500 commented Aug 22, 2022

Copy link
Copy Markdown

It allows to access binary data for specific QRCodes. In our case we use it to store MessagePack data and the data property returned by jsQR is empty, but not the binaryData. That's why I think it can be useful to also have it in this library.

image

@vrabe

vrabe commented Sep 5, 2022

Copy link
Copy Markdown

It is also helpful for data not encoded in utf8.

@pgolovkin

Copy link
Copy Markdown

Great feature! May it be merged soon?

@megatol

megatol commented Aug 16, 2023

Copy link
Copy Markdown

I just tested this patch and it works great. This fixes both #227 and #184. Why can't we get it merged?

@Arno500

Arno500 commented Aug 16, 2023

Copy link
Copy Markdown
Author

Maybe we can get a quick review from @danimoh ?
Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants