Enable use native BarcodeDetector on MacOS Ventura with M chips#243
Open
alsherko wants to merge 1 commit into
Open
Enable use native BarcodeDetector on MacOS Ventura with M chips#243alsherko wants to merge 1 commit into
alsherko wants to merge 1 commit into
Conversation
sisou
requested changes
Aug 22, 2023
sisou
left a comment
Member
There was a problem hiding this comment.
Instead of removing the check for M* Macs completely, it should still detect and use the workaround in Chromium versions <113.
sisou
reviewed
Aug 22, 2023
sisou
approved these changes
Aug 22, 2023
|
Any chance this gets merged? |
laszlo1337
added a commit
to laszlo1337/qr-scanner
that referenced
this pull request
Dec 12, 2023
laszlo1337
added a commit
to laszlo1337/qr-scanner
that referenced
this pull request
Dec 12, 2023
laszlo1337
added a commit
to laszlo1337/qr-scanner
that referenced
this pull request
Dec 12, 2023
laszlo1337
added a commit
to laszlo1337/qr-scanner
that referenced
this pull request
Dec 12, 2023
laszlo1337
added a commit
to laszlo1337/qr-scanner
that referenced
this pull request
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue https://bugs.chromium.org/p/chromium/issues/detail?id=1382442 Verified in Chrome 113.0.5620.0.
Returned the use of native BarcodeDetector on MacOS Ventura with M chips