Skip to content

Enable use native BarcodeDetector on MacOS Ventura with M chips#243

Open
alsherko wants to merge 1 commit into
nimiq:masterfrom
alsherko:master
Open

Enable use native BarcodeDetector on MacOS Ventura with M chips#243
alsherko wants to merge 1 commit into
nimiq:masterfrom
alsherko:master

Conversation

@alsherko

Copy link
Copy Markdown

Issue https://bugs.chromium.org/p/chromium/issues/detail?id=1382442 Verified in Chrome 113.0.5620.0.

Returned the use of native BarcodeDetector on MacOS Ventura with M chips

@alsherko alsherko changed the title Enable native BarcodeDetector on M chips with Ventura Enable use native BarcodeDetector on MacOS Ventura with M chips Aug 20, 2023

@sisou sisou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing the check for M* Macs completely, it should still detect and use the workaround in Chromium versions <113.

Comment thread src/qr-scanner.ts
@alsherko alsherko requested a review from sisou August 22, 2023 09:44

@sisou sisou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, handing over to @danimoh

Comment thread src/qr-scanner.ts Outdated
@laszlo1337

Copy link
Copy Markdown

Any chance this gets merged?

laszlo1337 added a commit to laszlo1337/qr-scanner that referenced this pull request Dec 12, 2023
laszlo1337 added a commit to laszlo1337/qr-scanner that referenced this pull request Dec 12, 2023
laszlo1337 added a commit to laszlo1337/qr-scanner that referenced this pull request Dec 12, 2023
laszlo1337 added a commit to laszlo1337/qr-scanner that referenced this pull request Dec 12, 2023
laszlo1337 added a commit to laszlo1337/qr-scanner that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants