Add modified_file_threshold_seconds setting #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified_file_threshold_seconds - skips compaction for files older than specified threshold
nagraham
reviewed
Aug 21, 2025
| iceberg-datafusion = { workspace = true } | ||
| itertools = "0.13.0" | ||
| mixtrics = "0.2.0" | ||
| object_store = { version = "0.11", features = ["aws"] } |
There was a problem hiding this comment.
One alternative is OpenDAL. I call it out because it's already used by the iceberg crate. It abstracts over different object stores (including S3 compatible stores), but object_store does that as well.
There is a read Operator that has a stat() function (docs) which returns Metadata, which has last_modified (docs).
Comment on lines
+144
to
+147
| /// Threshold in seconds for file modification time filtering (default: 0, means include all files) | ||
| /// Only files modified within this many seconds from now will be included in compaction | ||
| #[builder(default = "DEFAULT_MODIFIED_FILE_THRESHOLD_SECONDS")] | ||
| pub modified_file_threshold_seconds: u64, |
There was a problem hiding this comment.
Maybe we should call out in that is currently only supported with tables that object stores with s3-compatible APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified_file_threshold_seconds - skips compaction for files older than specified threshold