allow k8s-nameserver to read dnsrecords directly#12
Merged
thirdeyenick merged 1 commit intomainfrom May 14, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build 15001012253Details
💛 - Coveralls |
thirdeyenick
force-pushed
the
allow-direct-configmap-watch
branch
from
2ef3ab3 to
938ebfa
Compare
ctrox
reviewed
May 12, 2025
thirdeyenick
force-pushed
the
allow-direct-configmap-watch
branch
3 times, most recently
from
e915b70 to
419f6b7
Compare
This adds an argument for the k8s-nameserver to watch and read the dnsrecods configMap directly. As the default way of mount propagating the dnsrecords might take some time to sync when the configMap updates, reading and watching the configMap directly should reduce this time.
thirdeyenick
force-pushed
the
allow-direct-configmap-watch
branch
from
419f6b7 to
d7df2bf
Compare
ctrox
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an argument for the k8s-nameserver to watch and read the dnsrecods configMap directly. As the default way of mount propagating the dnsrecords might take some time to sync when the configMap updates, reading and watching the configMap directly should reduce this time. This allows the DNS server to react quicker on tailscale proxy restarts.