ENH: Expand BOLD coregistration targets#546
Open
mgxd wants to merge 27 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
==========================================
+ Coverage 61.64% 61.87% +0.22%
==========================================
Files 73 74 +1
Lines 7057 7186 +129
Branches 868 883 +15
==========================================
+ Hits 4350 4446 +96
- Misses 2438 2465 +27
- Partials 269 275 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Establishes a consistent four-level hierarchy (orig → run → boldref → anat) to replace ad-hoc naming that hardcoded the session level and conflated "per-run boldref" with "coregistration reference". Key renames: - orig_boldref → run_boldref (per-run reference) - session_boldref → boldref_template (level-agnostic aggregated reference) - orig2session_xfm → run2boldref_xfm (internal fields and output filenames) - space-session → space-boldref (BIDS output entity) - HMC transform: from-orig_to-boldref → from-orig_to-run Legacy fallbacks in utils/derivatives.py handle precomputed derivatives written under the old naming convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #517
Adds
--bold-coreg-level, which allows setting the BOLD coregistration level as either:run(current behavior, a separate reference image is calculated and registered to the anatomical reference independently for each run) orsession(all run-level BOLD references within a session are combined into a session template before registering to anatomical).