Skip to content

TST: Test the trivial model instantiation through the model factory #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

TST: Test the trivial model instantiation through the model factory #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ def test_model_factory_invalid_model():
@pytest.mark.parametrize(
"name, expected_cls",
[
("trivial", model.TrivialModel),
("avg", model.ExpectationModel),
("average", model.ExpectationModel),
("mean", model.ExpectationModel),
Expand All @@ -242,6 +243,14 @@ def test_factory_variants(name, expected_cls, setup_random_base_data):
motion_affines=motion_affines,
datahdr=datahdr,
)
if name == "trivial":
# ToDo
# Does not work because BaseDataset does not have a reference property
# ToDo
# Test the bzero case
# ToDo
# Test the predicted case
setattr(dataset, "reference", np.zeros(dataobj.shape[:3]))
model_instance = model.ModelFactory.init(name, dataset=dataset)
assert isinstance(model_instance, expected_cls)

Expand Down
Loading