[ENH] Allow override of webapi-url from URL parameter - #238
Conversation
42cf0e6 to
ea37074
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 66.45% 66.75% +0.29%
==========================================
Files 27 27
Lines 3023 3023
Branches 401 401
==========================================
+ Hits 2009 2018 +9
+ Misses 897 892 -5
+ Partials 117 113 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8cb96ae to
3db1cdc
Compare
3b532d6 to
42f09c1
Compare
effigies
left a comment
There was a problem hiding this comment.
This falls back to current behavior, so LGTM as something to be going on with. Will merge after a day if no further discussion.
|
Why cannot it be done at generation time using |
|
It is more for the case where API endpoint is unknown at generation, or might depend on which platform the generated reports get reviewed on. We do not have an implemented usecase now, but I am looking into being able to open reports and have the rating widget point to some webhooks to save the results in a datalad dataset. As this is in a distributed multi-site setting, this URL might change depending on the environment. |
|
This would also require passing a token (or unset it). I'm wondering, why not grep + sed twice (one sed for the url, one for the token)? |
Simple attempt at implementing nipreps/mriqc#1422 .