ENH: Add improved motion plotting capabilities - #257
Conversation
|
@mnoergaard Can you please paste here what this looked like in PETPrep so that I can have a reference to work with? Also, I am wondering whether this can be generalized to any other parameter that we are willing to plot after a pre-processing step. |
89a78d3 to
4df03d9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 66.56% 68.62% +2.05%
==========================================
Files 27 27
Lines 3030 3254 +224
Branches 401 428 +27
==========================================
+ Hits 2017 2233 +216
- Misses 897 902 +5
- Partials 116 119 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Thanks @mnoergaard. Can you please share the necessary data so that I can try reproducing it? |
a87907a to
69202ec
Compare
958ed8c to
5ebef58
Compare
|
This is ready on my end. Thanks @mnoergaard for the original work and for your help behind the scenes.
Some notes:
please let me know.
This can be left for a separate PR/for whenever the need surfaces; the bottom lineplot could be parameterized to display another parameter. |
f89073e to
0b5ebef
Compare
|
By the way, is th SVG supposed to be animated or interactive (i.e. triggered by hovering) @mnoergaard? The original documentation says it is interactive but I'd say that it is animated. |
Add improved motion plotting capabilities: an interactive head motion correction plot with animated before/after correction frames and optional framewise displacement lineplot. Add the corresponding interface. Add tests covering the plotting capabilities. Add `imageio` as an additional dependency and update the `uv.lock` file. This feature was originally contributed to the PETPrep project by Martin Norgaard: nipreps/petprep#171 This PR transfers and refactors that work so it can be reused across the NiPreps projects. Co-Authored-By: Martin Norgaard <martin.noergaard@nru.dk>
0b5ebef to
cf72829
Compare

Add improved motion plotting capabilities: an interactive head motion correction plot with animated before/after correction frames and optional framewise displacement lineplot.
Add the corresponding interface.
Add tests covering the plotting capabilities.
Add
imageioas an additional dependency and update theuv.lockfile.This feature was originally contributed to the PETPrep project by Martin Norgaard:
nipreps/petprep#171
This PR transfers and refactors that work so it can be reused across the NiPreps projects.
Co-Authored-By: Martin Norgaard martin.noergaard@nru.dk