Open
Conversation
|
Hello @effigies, Thank you for updating!
To test for issues locally, Comment last updated at 2021-11-19 13:45:48 UTC |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1066 +/- ##
==========================================
- Coverage 95.34% 94.91% -0.43%
==========================================
Files 209 210 +1
Lines 29777 29917 +140
Branches 3357 3380 +23
==========================================
+ Hits 28390 28396 +6
- Misses 948 1073 +125
- Partials 439 448 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@effigies thanks for supporting this. The mz3 specification is here.
Happy to work directly with you to tidy this up. |
effigies
commented
Apr 22, 2025
effigies
commented
Apr 22, 2025
effigies
commented
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently implements reading the header and "scalar" array. Haven't tested if we need to switch ordering to handle multiple scalar arrays. Does not yet implement reading vertices, faces or rgba.
Two significant wrinkles to this format:
member-size mod 2**32field in the gzip footer to detect the size. If we hit 20GB we bet that it's a weird file and just seek to the end of the gzip stream.Loading face/header data will be a good test for BIAP 0009 (#1056), but don't want to clog up that PR at the moment.