RF: Unify Caret-XML-style metadata structure as dict-like#1091
Merged
effigies merged 7 commits intonipy:masterfrom Feb 25, 2022
Merged
RF: Unify Caret-XML-style metadata structure as dict-like#1091effigies merged 7 commits intonipy:masterfrom
effigies merged 7 commits intonipy:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1091 +/- ##
==========================================
+ Coverage 92.27% 92.29% +0.02%
==========================================
Files 99 100 +1
Lines 12228 12247 +19
Branches 2392 2393 +1
==========================================
+ Hits 11283 11303 +20
Misses 621 621
+ Partials 324 323 -1
Continue to review full report at Codecov.
|
effigies
force-pushed
the
enh/unify_xml_metadata
branch
from
b91b697 to
a95ff51
Compare
jbteves
approved these changes
Feb 25, 2022
jbteves
left a comment
jbteves
left a comment
There was a problem hiding this comment.
LGTM with the caveat that I'm not sure what the approval checklist for nibabel looks like 😉
htwangtw
approved these changes
Feb 25, 2022
Contributor
htwangtw
left a comment
htwangtw
left a comment
There was a problem hiding this comment.
LGTM! A more parsable gifti metadata makes me really happy.
Member
Author
|
Reviewing guidelines: https://nipy.org/nibabel/devel/core_developer.html#reviewing |
effigies
force-pushed
the
enh/unify_xml_metadata
branch
from
a95ff51 to
6bc86df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have two implementations of the same structure in GIFTI and CIFTI-2. The Cifti one is much nicer to deal with, but also a little short of a straight drop-in replacement for
dict().Spurred by writing a parser for
CaretSpecFiles in #1090. Mostly used the Cifti implementation, but dropped thedifference_update()(not sure why this exists, so don't want to copy it without a use case). Used a private_dataobject to allow theGiftiMetaData.datato be a deprecated list view.Scheduled dropping most of the custom bits of each subclass for 6.0 to give a good long warning period.