ENH: Add minimal support for TRKv3 #1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW I have emailed trackvis support. If I hear back, we might have something more useful to put in. |
Codecov Report
@@ Coverage Diff @@
## master #1125 +/- ##
==========================================
- Coverage 91.76% 91.74% -0.02%
==========================================
Files 101 101
Lines 12380 12382 +2
Branches 2423 2424 +1
==========================================
Hits 11360 11360
- Misses 693 694 +1
- Partials 327 328 +1
Continue to review full report at Codecov.
|
|
Minimal change, so I'll merge without review at this point. Happy to accept fixes in further PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1123.
This is not ideal, but if TrackVis is producing v3 files without documenting what's in them, I can't see many better options.
The example data file I was given does successfully parse, but at 240MB (and possibly not available for public distribution), I will skip including it as a test file.
@MarcCote @jchoude I don't know if you've got any insights here...