ENH: Add to/from_stream methods and from_url classmethod to SerializableImage #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1129 +/- ##
==========================================
+ Coverage 91.74% 91.78% +0.03%
==========================================
Files 101 101
Lines 12382 12392 +10
Branches 2424 2424
==========================================
+ Hits 11360 11374 +14
+ Misses 694 692 -2
+ Partials 328 326 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
effigies
commented
Aug 20, 2022
|
Anybody interested in reviewing? |
|
Sorry - yes - will do - tomorrow. |
Probably. Feels like a bit of a can of worms that I didn't want to open in this PR. Okay to push off to another one? |
effigies
changed the title
Yes, that's fine. |
|
LGTM |
|
Thanks! |
This was referenced Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #639 to allow
from_url()to load an image. Does not currently handle gzipped (see #1128 for some more discussion) streams, though this should be doable.Abstracts to using
io.IOBaseto permit easy extension to other streams, but does not expose it generically at this point.Tested to work on https://openneuro.org/crn/datasets/ds000117/snapshots/1.0.5/files/sub-01:ses-mri:fmap:sub-01_ses-mri_magnitude1.nii and a
file:///...option.