MNT: Re-add pyproject.toml #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
mnt/pyproject
branch
3 times, most recently
from
af422e4 to
a7cd030
Compare
effigies
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1133 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 101 101
Lines 12445 12445
Branches 2430 2430
=======================================
Hits 11425 11425
Misses 693 693
Partials 327 327 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
effigies
force-pushed
the
mnt/pyproject
branch
from
541537c to
7ee6327
Compare
matthew-brett
approved these changes
Sep 7, 2022
|
Nope, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time to try using more modern build metadata again.
pyproject.tomlto mark build-time dependencies, which also allows us to move to the non-vendored flavor of versioneersetup.cfg. I don't really want to rewrite the extras interpolation, so I'm marking that dynamic for now.@matthew-brett I've verified that
pip install --user -e .works with recent setuptools, which was the issue in #859 that made us drop this before.