CI: Build, test and deploy packages #1134
Conversation
effigies
force-pushed
the
ci/build-test-deploy
branch
from
30a7f5e to
f1678f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1134 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 101 101
Lines 12445 12445
Branches 2430 2430
=======================================
Hits 11425 11425
Misses 693 693
Partials 327 327 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Hey Chis @effigies this is just to show the at-mention Github feature. |
|
@oesteban - could you have a look here too? |
|
Hi @matthew-brett any objections? |
| with: | ||
| name: pytest-results-${{ matrix.os }}-${{ matrix.python-version }} | ||
| path: for_testing/test-results.xml | ||
| if: ${{ always() && matrix.check == 'test' }} | ||
|
|
||
| publish: |
There was a problem hiding this comment.
I feel just a little squeamish about directly pushing to PyPI on tagging, but it's really your call as release manager.
There was a problem hiding this comment.
The reason that I want to do this is because with 4.0.0, there were tests that passed, then I tagged, and forgot to test on the tagged version before publishing. DeprecationWarnings mutated into ExpiredDeprecationErrors and we had a release that failed its own tests.
That said, it looks like I can create an environment that requires manual review before providing access to the PYPI token. Would that feel more comfortable?
There was a problem hiding this comment.
Honesty - your call - you're doing the releases.
|
Thanks for the review. |
Taking advantage of GitHub's workflow, I'm thinking of moving from the Travis-like mono-workflow to one that builds the packages, uploads them as archives, and then runs tests in the absence of the repository. This test is not intended to replace the full matrix, but to make sure that the artifacts we're publishing are tested in isolation.
This will also ensure that builds get pushed to PyPI only after successfully testing the tagged release, removing one source of human error.