ENH: Assume TCK is open in binary mode #1142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 91.81% // Head: 91.81% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1142 +/- ##
==========================================
- Coverage 91.81% 91.81% -0.01%
==========================================
Files 101 101
Lines 12469 12463 -6
Branches 2239 2238 -1
==========================================
- Hits 11449 11443 -6
Misses 693 693
Partials 327 327
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MarcCote
approved these changes
Nov 18, 2022
Co-authored-by: Chris Markiewicz <[email protected]>
|
Failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current TCK code makes some conversions between text and binary when reading and writing, which should not be required: the file should be open in binary mode, as it contains binary information after the text-encoded header.
This PR addresses this by assuming the file handler is in binary mode.
As a minor change, it changes the logic on computing the data offset considering the length of the length representation (chicken-egg thing). It will always be at max +1 char to represent the length.