Skip to content

MNT: Apply pyupgrade suggestions #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 91.81% // Head: 91.81% // No change to project coverage 👍

Coverage data is based on head (5529d85) compared to base (d33a05a).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1154   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files         101      101           
  Lines       12463    12463           
  Branches     2238     2238           
=======================================
  Hits        11443    11443           
  Misses        693      693           
  Partials      327      327           
Impacted Files Coverage Δ
nibabel/freesurfer/io.py 94.24% <0.00%> (ø)
nibabel/nifti1.py 92.63% <ø> (ø)
nibabel/nifti2.py 94.59% <ø> (ø)
nibabel/volumeutils.py 93.08% <75.00%> (ø)
nibabel/cifti2/cifti2.py 96.85% <100.00%> (ø)
nibabel/cmdline/ls.py 77.21% <100.00%> (ø)
nibabel/cmdline/parrec2nii.py 90.41% <100.00%> (ø)
nibabel/ecat.py 88.07% <100.00%> (ø)
nibabel/filebasedimages.py 92.05% <100.00%> (ø)
nibabel/gifti/gifti.py 87.78% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft December 12, 2022 20:43
@DimitriPapadopoulos DimitriPapadopoulos changed the title Apply pyupgrade suggestions MNT: Apply pyupgrade suggestions Dec 12, 2022
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these look good.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review December 13, 2022 14:53
@effigies effigies merged commit 0bb649e into nipy:master Dec 15, 2022
@DimitriPapadopoulos DimitriPapadopoulos deleted the pyupgrade branch December 15, 2022 19:23
@effigies effigies added this to the 5.0.0 milestone Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants