MNT: 5.0.0 deprecations #1159
Merged
MNT: 5.0.0 deprecations #1159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the expiration more obvious than a single line at the end, as well as prevents doctests from raising ExpiredDeprecationErrors
Codecov ReportBase: 92.40% // Head: 92.38% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1159 +/- ##
==========================================
- Coverage 92.40% 92.38% -0.03%
==========================================
Files 98 98
Lines 12248 12264 +16
Branches 2516 2520 +4
==========================================
+ Hits 11318 11330 +12
- Misses 611 613 +2
- Partials 319 321 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few issues missed by #1141, found by tagging and re-running tests.
Main changes:
Add an
@expires(version)decorator that will turn tests intoxfail(raises=ExpiredDeprecationError)when the version comes around. This means we can continue testing the functionality as long as it actually exists without needing to delete a bunch of tests just before we release.Truncate docstrings after expiration. We don't need detailed descriptions of behavior that no longer is actually present, and doctests are basically guaranteed to fail.
Allow
pytest.marks to be set on API validator methods.