-
Notifications
You must be signed in to change notification settings - Fork 261
ENH: Support multiline header fields in TCK #1175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 92.39% // Head: 92.39% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1175 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 97 97
Lines 12264 12264
Branches 2525 2525
=======================================
Hits 11331 11331
Misses 613 613
Partials 320 320 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
c6f3643
to
55e3e06
Compare
Any chance of a review? I'm comfortable with the test coverage and will plan to merge tomorrow unless someone asks me to wait. |
Treat repeated keys as adding lines to the field Closes nipygh-957
55e3e06
to
95df42e
Compare
This looks good to me, thanks for revisiting it @effigies! |
Thanks for the review! And thanks for your patience with the... sporadic activity here. |
Thanks @effigies for maintaining this code :). |
Getting back- |
@mattcieslak's initial PR was lost in the refactor by @anibalsolon in #1140. This PR takes the data file shared by @valeriejill, with just the first streamline (zeroed out) to confirm that a header that was failing to be read now can be. I've also added an extra
command_history
line later in the header to ensure that we aggregate duplicate keys instead of overwrite, in response to #957 (comment) by @thijsdhollander.@valeriejill can you confirm that we have permission to publish this file as part of our test data? If not, I think I've learned enough about working with the format to make my own.
@anibalsolon @MarcCote I would appreciate code reviews from you.
Closes #957.