TYP: Add a version stub to allow mypy to run without building#1210
Merged
effigies merged 1 commit intonipy:masterfrom Mar 7, 2023
Merged
TYP: Add a version stub to allow mypy to run without building#1210effigies merged 1 commit intonipy:masterfrom
effigies merged 1 commit intonipy:masterfrom
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1210 +/- ##
==========================================
+ Coverage 92.06% 92.14% +0.08%
==========================================
Files 97 97
Lines 12334 12334
Branches 2534 2534
==========================================
+ Hits 11355 11365 +10
+ Misses 655 647 -8
+ Partials 324 322 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @Factral in #1208 (comment) I realized that we could probably make the contribution process a little nicer to people not wanting to
pip install -eorhatch build --hooks-onlyjust to make the pre-commit hooks run cleanly.This adds a
_version.pyithatmypywill respect without even checking whether_version.pyis present.The biggest potential risk is
setuptools-scmchanging the contents of_version.pyin the future, but that seems low and a thing we can deal with if it comes up.No need to backport unless we get contributors to a maintenance branch.
Verifying:
Reverting to
master: