ENH: Expand CIFTI2 constants to use a synonym recoder#1256
Merged
effigies merged 2 commits intonipy:masterfrom Sep 22, 2023
Merged
ENH: Expand CIFTI2 constants to use a synonym recoder#1256effigies merged 2 commits intonipy:masterfrom
effigies merged 2 commits intonipy:masterfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1256 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 99 99
Lines 12456 12458 +2
Branches 2559 2560 +1
=======================================
+ Hits 11484 11486 +2
Misses 648 648
Partials 324 324
☔ View full report in Codecov by Sentry. |
Member
Author
|
@mgxd Would you mind having a look when you get a chance? |
mgxd
approved these changes
Sep 19, 2023
Member
mgxd
left a comment
mgxd
left a comment
There was a problem hiding this comment.
Few things, otherwise looks good
Co-authored-by: Mathias Goncalves <goncalves.mathias@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For increased flexibility in the CIFTI2 axes API, this creates a set of synonyms for different CIFTI structures, mapping them onto the
CIFTI_STRUCTURE_*.Used for resolving synonyms in caret spec files in #1090, but mergeable on its own.