WIP: generalize class for opening image#1314
Open
matthew-brett wants to merge 1 commit intonipy:masterfrom
Open
WIP: generalize class for opening image#1314matthew-brett wants to merge 1 commit intonipy:masterfrom
matthew-brett wants to merge 1 commit intonipy:masterfrom
Conversation
Allow FileHolder subclasses to change the ImageOpener class.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1314 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 99 99
Lines 12472 12473 +1
Branches 2566 2566
=======================================
+ Hits 11507 11508 +1
Misses 642 642
Partials 323 323 ☔ View full report in Codecov by Sentry. |
Member
We could pull that out of the if ty.TYPE_CHECKING:
from nibabel.openers import OpenerDef |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow FileHolder subclasses to change the ImageOpener class.
I wanted to do this to work with the
fsspecfile objects.But - I couldn't see immediately what the right way to do the type checking is
openers.py, but that is only definedif
ty.TYPE_CHECKINGis True. I'd love some advice!