[MAINT] apply pre-commit autofixes by Remi-Gau · Pull Request #1468 · nipy/nibabel

Remi-Gau · 2026-02-26T19:33:26Z

related to [WIP][MAINT] bump pre-commit hooks versions #1467
simply run pre-commit on all files
mostly adds an explicit strict to all zip()
ignore a couple of other errors that would require manual fixes
adapts a conditional import that is always true since we are always on >= 3.10

Remi-Gau · 2026-02-26T19:34:22Z

pyproject.toml

+    "RUF007",
    "RUF012", # TODO: enable
    "RUF015",
    "RUF017", # TODO: enable
+    "UP007",
+    "UP038",
+    "TC003",


ignore those new errors for now, but I could either try to fix them in this PR or have side PRs for it

I don't like UP038. It's churn for its own sake, and I've seen Python core devs regret making unions isinstance-able, since it doesn't work for many other type forms.

I think we should adopt UP007. The other two I don't care about one way or the other. If they have auto-fixes, fine, but I'm okay with ignoring as well.

Feel free to include in this PR if you've got the time/energy, but I'm okay with modular PRs done as time permits.

codecov · 2026-02-26T22:01:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.42%. Comparing base (673962f) to head (9bf33e7).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1468   +/-   ##
=======================================
  Coverage   95.42%   95.42%           
=======================================
  Files         209      209           
  Lines       29822    29820    -2     
  Branches     4483     4482    -1     
=======================================
  Hits        28457    28457           
+ Misses        930      929    -1     
+ Partials      435      434    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

effigies

I suppose that we should prefer strict=True when there is no good reason for the lengths to differ? Or is it more efficient to use strict=False, and so we only prefer strict=True if they can differ and should error?

I strongly suspect that most could be strict, but here are a few that I have verified manually.

effigies · 2026-02-27T14:26:19Z

nibabel/wrapstruct.py

    def items(self):
        """Return items from structured data"""
-        return zip(self.keys(), self.values())
+        return zip(self.keys(), self.values(), strict=False)


These should never be different.

Suggested change

return zip(self.keys(), self.values(), strict=False)

return zip(self.keys(), self.values(), strict=True)

effigies · 2026-02-27T18:06:18Z

nibabel/viewers.py

                ['right', 'center'],
            ]
-            for pos, anchor, lab in zip(poss, anchors, label):
+            for pos, anchor, lab in zip(poss, anchors, label, strict=False):


Suggested change

for pos, anchor, lab in zip(poss, anchors, label, strict=False):

for pos, anchor, lab in zip(poss, anchors, label, strict=True):

effigies · 2026-02-27T18:06:26Z

nibabel/viewers.py

            ax.set_xlim(x[0], x[-1])
            yl = [self._data.min(), self._data.max()]
-            yl = [lim + s * np.diff(lims)[0] for lim, s in zip(yl, [-1.01, 1.01])]
+            yl = [lim + s * np.diff(lims)[0] for lim, s in zip(yl, [-1.01, 1.01], strict=False)]


Suggested change

yl = [lim + s * np.diff(lims)[0] for lim, s in zip(yl, [-1.01, 1.01], strict=False)]

yl = [lim + s * np.diff(lims)[0] for lim, s in zip(yl, [-1.01, 1.01], strict=True)]

effigies · 2026-02-27T18:06:39Z

nibabel/viewers.py

        idxs = np.dot(self._inv_affine, self._position)[:3]
        idxs_new_order = idxs[self._order]
-        for ii, (size, idx) in enumerate(zip(self._sizes, idxs_new_order)):
+        for ii, (size, idx) in enumerate(zip(self._sizes, idxs_new_order, strict=False)):


Suggested change

for ii, (size, idx) in enumerate(zip(self._sizes, idxs_new_order, strict=False)):

for ii, (size, idx) in enumerate(zip(self._sizes, idxs_new_order, strict=True)):

effigies · 2026-02-27T18:07:05Z

nibabel/viewers.py

        self._sizes = [self._data.shape[order] for order in self._order]
        for ii, xax, yax, ratio, label in zip(
-            [0, 1, 2], [1, 0, 0], [2, 2, 1], r, ('SAIP', 'SRIL', 'ARPL')
+            [0, 1, 2], [1, 0, 0], [2, 2, 1], r, ('SAIP', 'SRIL', 'ARPL'), strict=False


Suggested change

[0, 1, 2], [1, 0, 0], [2, 2, 1], r, ('SAIP', 'SRIL', 'ARPL'), strict=False

[0, 1, 2], [1, 0, 0], [2, 2, 1], r, ('SAIP', 'SRIL', 'ARPL'), strict=True

effigies · 2026-02-27T18:07:54Z

nibabel/spaces.py

            raise ValueError('voxel sizes should all be positive')
        out_vox[:n_axes] = voxel_sizes
-    in_mn_mx = zip([0, 0, 0], np.array(in_shape) - 1)
+    in_mn_mx = zip([0, 0, 0], np.array(in_shape) - 1, strict=False)


Suggested change

in_mn_mx = zip([0, 0, 0], np.array(in_shape) - 1, strict=False)

in_mn_mx = zip([0, 0, 0], np.array(in_shape) - 1, strict=True)

effigies · 2026-02-27T18:08:10Z

nibabel/orientations.py

           [ 2.,  1.]])
    """
-    labels = list(zip('LPI', 'RAS')) if labels is None else labels
+    labels = list(zip('LPI', 'RAS', strict=False)) if labels is None else labels


Suggested change

labels = list(zip('LPI', 'RAS', strict=False)) if labels is None else labels

labels = list(zip('LPI', 'RAS', strict=True)) if labels is None else labels

effigies · 2026-02-27T18:08:17Z

nibabel/orientations.py

    """
    if labels is None:
-        labels = list(zip('LPI', 'RAS'))
+        labels = list(zip('LPI', 'RAS', strict=False))


Suggested change

labels = list(zip('LPI', 'RAS', strict=False))

labels = list(zip('LPI', 'RAS', strict=True))

[MAINT] apply pre-commit autofixes

9bf33e7

Remi-Gau commented Feb 26, 2026

View reviewed changes

effigies reviewed Feb 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MAINT] apply pre-commit autofixes#1468

[MAINT] apply pre-commit autofixes#1468
Remi-Gau wants to merge 1 commit intonipy:masterfrom
Remi-Gau:apply/precommit

Remi-Gau commented Feb 26, 2026

Uh oh!

Remi-Gau Feb 26, 2026

Uh oh!

effigies Feb 27, 2026

Uh oh!

codecov bot commented Feb 26, 2026 •

edited

Loading

Uh oh!

effigies left a comment

Uh oh!

effigies Feb 27, 2026

Uh oh!

effigies Feb 27, 2026

Uh oh!

effigies Feb 27, 2026

Uh oh!

effigies Feb 27, 2026

Uh oh!

effigies Feb 27, 2026

Uh oh!

effigies Feb 27, 2026

Uh oh!

effigies Feb 27, 2026

Uh oh!

effigies Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	return zip(self.keys(), self.values(), strict=False)
	return zip(self.keys(), self.values(), strict=True)

	for pos, anchor, lab in zip(poss, anchors, label, strict=False):
	for pos, anchor, lab in zip(poss, anchors, label, strict=True):

	yl = [lim + s * np.diff(lims)[0] for lim, s in zip(yl, [-1.01, 1.01], strict=False)]
	yl = [lim + s * np.diff(lims)[0] for lim, s in zip(yl, [-1.01, 1.01], strict=True)]

	for ii, (size, idx) in enumerate(zip(self._sizes, idxs_new_order, strict=False)):
	for ii, (size, idx) in enumerate(zip(self._sizes, idxs_new_order, strict=True)):

	[0, 1, 2], [1, 0, 0], [2, 2, 1], r, ('SAIP', 'SRIL', 'ARPL'), strict=False
	[0, 1, 2], [1, 0, 0], [2, 2, 1], r, ('SAIP', 'SRIL', 'ARPL'), strict=True

	in_mn_mx = zip([0, 0, 0], np.array(in_shape) - 1, strict=False)
	in_mn_mx = zip([0, 0, 0], np.array(in_shape) - 1, strict=True)

	labels = list(zip('LPI', 'RAS', strict=False)) if labels is None else labels
	labels = list(zip('LPI', 'RAS', strict=True)) if labels is None else labels

Conversation

Remi-Gau commented Feb 26, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

effigies left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Feb 26, 2026 •

edited

Loading