-
Notifications
You must be signed in to change notification settings - Fork 262
ENH: Define Cifti2 Axes describing the rows/columns of the Cifti2 data #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 38 commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
87c7dc1
ENH: Define Cifti2 Axes describing the rows/columns of the Cifti2 data
MichielCottaar 0e7566a
Clarified the test filenames
MichielCottaar 671c196
BUG: removed failing doctest
MichielCottaar 1dd059d
DOC: explained that Axis is an abstract class
MichielCottaar 8660afd
RF: removed the typed array underlying all axes
MichielCottaar c2274c5
RF: increased consistency of methods in the Axis objects
MichielCottaar 52aff8a
ENH: made it easier to create Label axis from constructor directly
MichielCottaar dad74ee
REF: made flake8 happy
MichielCottaar a0e8ff3
BF: fixed abstract class for python2
MichielCottaar 420dacb
BF: allow any integer type, not just int
MichielCottaar 29448f1
DOC: fixed many issues with the documentation
MichielCottaar 5684268
RF: made flake8 happy again
MichielCottaar fbd28dc
Apply suggestions from code review
effigies c33e0d1
Added other reviewer suggestions
MichielCottaar bc2064e
RF: remove spurious ', ' from method definition
MichielCottaar 4c0f389
Replaced asarray with asanyarray
MichielCottaar 72c089a
reverse guard for incorrect type when concatenating parcels
MichielCottaar e8bcaba
Replaces type(self) with self.__class__
MichielCottaar ac2618b
Tests many more fail conditions and edge cases
MichielCottaar e00143b
MNT: Bump minimum numpy version to 1.8
effigies 436231c
Apply suggestions from code review
effigies d1bc7fe
BF: only set idx_start to size - 1 for negative step
MichielCottaar 949da0e
TEST: add tests for Axis __eq__ methods
MichielCottaar ac0258c
DOC: removed Series attribute list as it is already listed in the __i…
MichielCottaar 6726b00
RF: removed separate `extend` method
MichielCottaar 790aba4
BF: report original index
MichielCottaar e7302d6
RF: removed spurious '+' when concatenating literal strings
MichielCottaar b2c674f
Increased test coverage
MichielCottaar 459fa88
RF: replaced last '.all()' with `array_equal`
MichielCottaar 70588f2
Merge branch 'master' into enh/cifti2_axes
MichielCottaar 6b55e11
RF: made flake8 happy again
MichielCottaar 2ae25b4
Merge pull request #2 from effigies/enh/cifti2_axes
MichielCottaar e4bc7b0
BF: don't use np.full to create string array
MichielCottaar a5f88c2
RF: set surface BrainModel default structure to Other
MichielCottaar a31af61
RF: adjusted some type desciptions
MichielCottaar 0e0b7f2
DOC: Added tutorial to docs
MichielCottaar 594b22f
BUG: skip doctests in example code
MichielCottaar 29a5287
BF: reduces line length in example code
MichielCottaar 109fa92
RF: changes from @demianw not involving name changes
MichielCottaar f7c47bb
RF: rename from_mapping to from_index_mapping
MichielCottaar b88d516
RF: return CIFTI_MODEL_TYPE to distinguish surface and voxels
MichielCottaar fd8593e
RF: renamed is_surface to surface_mask and added volume_mask
MichielCottaar cdf57db
STY: fixed indentation
MichielCottaar b51d5f1
DOC: consistently use CIFTI-2 instead of CIfTI2 or CIFTI2
MichielCottaar 532bed9
RF: appended Axis to the different axes classes
MichielCottaar cffb8c0
DOC: test creation of `bm_thal` and `bm_cortex`
MichielCottaar 9b2276d
DOC: got rid of most of the :class:`Axis` in tutorial
MichielCottaar 110334b
Update nibabel/cifti2/cifti2.py
effigies 063047f
Apply suggestions from code review
effigies cefb8c6
RF: replace ~surface_mask with volume_mask
MichielCottaar 0f0e1f7
DOC: added list of concrete classes to Axis object
MichielCottaar 0270ad9
BF: add name to return, so that link works in html
MichielCottaar ed76418
RF: fix line length
MichielCottaar d825a3c
DOC: make format in list of axes more consistent
MichielCottaar 1bc459e
DOCTEST: Drop doctest SKIP directives
effigies 04a4b45
FIX: Use other.volume_mask to index other.voxel
effigies 4aa3609
DOC: Update docstrings with a few more links and array_like
effigies 97e16d3
Merge pull request #3 from effigies/enh/cifti2_axes
MichielCottaar 36c162d
BF: doctest fixes for tutorial
MichielCottaar 0927424
BF: fixed doctest for python 2.7
MichielCottaar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,7 @@ File Formats | |
analyze | ||
spm2analyze | ||
spm99analyze | ||
cifti2 | ||
gifti | ||
freesurfer | ||
minc1 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.