-
Notifications
You must be signed in to change notification settings - Fork 262
REL: 2.3.1 #667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
REL: 2.3.1 #667
Changes from 119 commits
Commits
Show all changes
168 commits
Select commit
Hold shift + click to select a range
328d3bb
RF: moved all the functionality from nib-ls under nibabel.cmdline
yarikoptic d293a20
ENH: added a skeleton for nib-diff command
yarikoptic 5491af4
TODO1 attempt 1: processed data type, data shape, and data offset of …
chrispycheng 949762c
tweaked to remove AnalyzeHeader but currently still has problems
chrispycheng 93b5e09
added nib-diff to setup.py
chrispycheng 22804f1
first attempt at nib-diff that doesnt work
chrispycheng f81a78b
removed incorrectly committed changes
chrispycheng fe9c052
BK: stab at the test_dict_diff
yarikoptic 5eb4477
first attempt at diff_dicts method and diff testing file
chrispycheng e2defb0
Merge branch 'nf-nib-diff' of https://github.com/yarikoptic/nibabel i…
chrispycheng 5e3a767
tried something else with header fields
chrispycheng 7febf65
latest attempt: restructured diff_dicts() method, troubleshooting ens…
chrispycheng 23a43ba
corrected misplacement of cmdline files and latest attempt at diff_di…
chrispycheng fae491d
progress! tweaked bugs, corrected rookie mistakes like cmdline placem…
chrispycheng 3e87d81
got rid of proc file and function works at a basic level
chrispycheng a3b35d9
tweaked diff_dicts to be compatible with tests
chrispycheng 1491c61
got rid of None, troubleshot tests
chrispycheng 397bc03
introduced hypothesis to use for testing with pretty sexy results
chrispycheng f192f65
noted hypothesis need for tests, refactored diff_dicts name
chrispycheng 92553a2
attempt at TODO#2: allowing specification of header fields
chrispycheng 7a70d56
now functional for several header files.
chrispycheng f5e930d
tweak to make hypothesis work with a list, but problem above has not …
chrispycheng df82a51
tweaked names and code as suggested!
chrispycheng 6d706f5
bug fix
chrispycheng 774ce3b
cosmetic tweaks
chrispycheng 911d781
cleaned up code
chrispycheng 0458694
promoted generic programming and got test to work again
chrispycheng fed70e9
tried to clean code but couldnt get comprehension going
chrispycheng 0b59dfb
comment and docstring
chrispycheng 2920abf
added options for text, json, yaml but still have to implement
chrispycheng 1e57409
work in progress with all outputs
chrispycheng fd6c474
simplified code but now bizarrely doesnt run with two files
chrispycheng 497ad2a
beautified text output, next up json and yaml
chrispycheng df0aa79
modified the tests for the new diff_values
chrispycheng c23143c
commenting out json and yaml, cosmetic mod to ls.py
chrispycheng db16d85
BF: all those flags are just boolean flags and no need to repeat thei…
yarikoptic feca439
progress towards table formatting
chrispycheng acf667b
table now works and looks p good
chrispycheng bb3fbf0
slight tweak to table formatting
chrispycheng 8a92010
very inefficient but successfully removed dtype when its identical
chrispycheng a9a572a
removed extra blank line lol
chrispycheng 3290a66
boosting coverage
chrispycheng 92e4ed0
Merge remote-tracking branch 'nibabel/master' into nf-nib-diff
chrispycheng 06e8dd7
data comparison function added
chrispycheng 8fd6995
implemented test-nib-diff
chrispycheng df8bc04
added another test
chrispycheng 45d3fbf
changed travis appveyor utils per test errors
chrispycheng 1cbf5b3
test files
chrispycheng 45bdf64
wasnt included in last commit by accident
chrispycheng c600746
maybe this will work instead
chrispycheng e26adb5
maybe this will work instead
chrispycheng 3802919
test fixed
chrispycheng 0ce86df
Merge branch 'nf-nib-diff' of https://github.com/yarikoptic/nibabel i…
chrispycheng 72bc800
fixed to be more generic
chrispycheng 0cf2a8c
fixed file name issue in nib diff
chrispycheng 5db2654
fixed changes as yarik requested
chrispycheng 50a480e
fixed problems noted by Travis CI
chrispycheng 9e155df
building in difflib to see whats going on
chrispycheng 3c0c90c
Merge branch 'master' into nf-nib-diff
effigies a494597
MAINT: 2.4.0-dev
effigies 89e698c
Merge branch 'maint/2.3.x' into HEAD
effigies 30c0bc5
DOC: Update changelog with release date
effigies f8c32b8
latest attempt at compliance changes dict to list
chrispycheng 51733b0
Merge branch 'nf-nib-diff' of https://github.com/yarikoptic/nibabel i…
chrispycheng 41caade
Remove unrelated to PR difference
yarikoptic f1cee5f
RF+BF: report that diff if any header of data differs, return dict of…
yarikoptic 676ac70
combined into one line
chrispycheng f476c48
new structure, names, tests
chrispycheng 10c2c42
hypothesis: all my problems were due to that one test
chrispycheng 7989563
whoops missed this
chrispycheng 71581ca
Fix in coordinate_systems tutorial
arokem 2a127cc
Merge pull request #646 from nipy/coordinate_systems_blooper
matthew-brett ae74339
i think im going to cry. code cleaned and made more pythonic
chrispycheng 82b1457
added and fixed tests
chrispycheng 45d0edf
fixing up appveyor and travis problems
chrispycheng c1f553f
fixed a fringe use case
chrispycheng 2f89242
style tweak for travis
chrispycheng 347eef9
BF: deterministic order of slice_time deduction, warning if multiple …
yarikoptic 7ba14b1
DOC: minor typo
yarikoptic 244c8cf
ENH(TST): basic test for consistent choice of slice_code in case of m…
yarikoptic 6613522
removed duplication, made things more generic
chrispycheng a311d7b
moved functionality outside to test and increase coverage
chrispycheng 748ce00
RF+NF: Use OrderedDict and OrderedSet in Recoder
yarikoptic a1400bd
ENH(TST): test that we issue a warning upon multiple matches
yarikoptic d756751
TEST: Ensure warning isn't suppressed
effigies bb8c6fa
Merge pull request #647 from yarikoptic/bf-sliceorder
effigies 2cd69b5
boosting coverage by testing main
chrispycheng 414da00
main test corrected for max coverage
chrispycheng 7fe10e6
FIX: Allow tr=0 in mghformat
larsoner f1ec04c
FIX: Better messages
larsoner 59006b0
imported StringIO from six instead of io
chrispycheng 672661e
added a test for cmdline function
chrispycheng 0f947a4
Merge pull request #653 from larsoner/tr
effigies baf6cdc
changes per Yariks comments!
chrispycheng 370c811
Replace genfromtxt with loadtxt
MichielCottaar 0408783
Merge pull request #617 from yarikoptic/nf-nib-diff
yarikoptic 897eb31
Merge pull request #655 from MichielCottaar/opt_genfromtxt
effigies caa04e4
BF: allow for PPC64 little endian long doubles
matthew-brett 3a13301
RF: remove redundant line
matthew-brett eb44d32
BF: fix missing width variable
matthew-brett be35aca
Merge pull request #658 from matthew-brett/ppc64le-fixes
effigies cd5a741
RF+ENH: nib-diff - allow to specify absolute and/or relative maximal …
yarikoptic 018eceb
ENH: nib-diff Field/File not just Field in the header
yarikoptic 833b4df
changed as commented out in the pull request
chrispycheng 9b123f6
changes as commented
chrispycheng 1e33ea7
RF: anticipated files of different shapes, fixed table display, corre…
chrispycheng 66fe79a
CI: Test on Python 3.7 on Travis
effigies 4b2f497
CI: Use dist xenial
effigies 62a664e
CI: Use matrix include for Python 3.7
effigies 0813c00
CI: Use Python 3.7-dev
effigies 7a0e298
DOCTEST: FutureWarning repr changed in 3.7
effigies 7c12c54
CI: Use 3.7 proper, move trusty+3.4 to matrix
effigies 2bd256b
TEST: Catch warnings in clear_and_catch tests
effigies 7baaf6b
CI: Add Python 3.7 to AppVeyor matrix
effigies b5dd5d7
FIX: Annotation labels are RGB, no alpha
effigies 10dbdda
TEST: Update tests to use RGB only
effigies 76ca32f
elaborated docstring, modified get_data_diff to allow direct array in…
chrispycheng 7b59675
DOC: Update ctab documentation, comments
effigies 25f08b7
CI: Drop extraneous 2.7 build on Travis
effigies 0aa6370
added to diff documentation, undid executable change, took out debugg…
chrispycheng 436df7c
Merge pull request #651 from nipy/ci/travis_py37
matthew-brett d057249
undid permission snafu on test_scripts
chrispycheng 7877add
Merge pull request #666 from effigies/fix/annot_labels
effigies dd24b20
Merge remote-tracking branch 'upstream/master' into rel/2.3.1
effigies 764584a
DOC: Update Changelog
effigies 1da1ac6
MNT: .mailmap
effigies e493b9d
MAINT: Drop -dev
effigies 906c6b4
MNT: Update YOH, CC initials
effigies 13d803f
TST: Require hypothesis>=3.7
effigies 76ee358
docstring and function name clarification, change get_data to get_fda…
chrispycheng 034c276
corrected styles per Travis, limited fdata to float32
chrispycheng 19fcdd5
STY: Break overly-long line
effigies 7e03807
ENH: Add ndim to ArrayProxy protocol
effigies c940dea
TEST: Validate expected ndim behavior
effigies 93c7bb6
prepared for future PR to allow modification of dtype used in diff co…
chrispycheng cd85e09
Merge branch 'enh-diff' of https://github.com/yarikoptic/nibabel into…
chrispycheng 97ead00
added cmdline functionality for modifying datatype used for file data…
chrispycheng d2d07d4
ENH: Pass ndim through to DataobjImage
effigies ce210bd
TEST: Validate DataobjImage.ndim
effigies 2340a92
added testing for dtype at cmdline, assuming cmdline functionality. c…
chrispycheng e8d3a4f
RF: do not use hypothesis
yarikoptic 09cfef1
BF: properly compare NaNs and test for >2 arguments given to are_valu…
yarikoptic 1996ead
RF: long -> large, NaN -> nan
yarikoptic 0fb8920
BF: reintroduce try/except guarding around initial np.isnan
yarikoptic e4c5b52
BF: exception string matching for not implemented in numpy 1.7.1
yarikoptic e87d581
BF: another workaround for elderly numpy 1.7.1
yarikoptic f973ce4
BF(DOC): fixed damn trailing whitespaces in a docsting
yarikoptic 7315931
storing changes for main testing
chrispycheng 22f89e9
Merge branch 'no-hypothesis' of https://github.com/yarikoptic/nibabel…
chrispycheng 3636c4d
added tests to fix coverage problem
chrispycheng 974a3a9
cmdline test added for dtype access
chrispycheng def0364
Merge pull request #678 from yarikoptic/no-hypothesis
yarikoptic 5361c7f
ENH: adjusted some strings etc to fit the width and avoid duplicate s…
yarikoptic edb72bc
Merge branch 'master' into enh-diff-dtype
effigies 679aa5b
Merge pull request #672 from chrispycheng/enh-diff-dtype
yarikoptic 65cb2b9
Revert "TST: Require hypothesis>=3.7"
effigies dd0b8ef
Merge remote-tracking branch 'upstream/master' into rel/2.3.1
effigies 791678e
Merge pull request #674 from effigies/enh/arrayproxy_ndim
effigies 72232e7
Merge remote-tracking branch 'upstream/master' into rel/2.3.1
effigies 0be50ad
DOC: Update changelog
effigies dc04379
TEST,BK: Update arrayproxy tests to test expected behaviour more thor…
pauldmccarthy 4efc5e3
TEST: Refactor keep_file_open tests to be more comprehensive
pauldmccarthy 5a9b7f3
BF,RF: Fix behaviour of keep_file_open flag. Now two internal flags a…
pauldmccarthy f6236ac
TEST: Avoid file close errors on windows
pauldmccarthy 9d7fb3f
TEST: Remove debug
pauldmccarthy a474254
Merge pull request #679 from pauldmccarthy/bf/fix_keep_file_open
effigies ba17006
Merge remote-tracking branch 'upstream/master' into rel/2.3.1
effigies 5841806
Update changelog
effigies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,7 @@ Basile Pinsard <[email protected]> bpinsard <[email protected]> | |
Nguyen, Ly <[email protected]> lxn2 <[email protected]> | ||
Ben Cipollini <[email protected]> Ben Cipollini <[email protected]> | ||
Chris Markiewicz <[email protected]> Christopher J. Markiewicz <[email protected]> | ||
Chris Markiewicz <[email protected]> Chris Markiewicz <[email protected]> | ||
Chris Markiewicz <[email protected]> Christopher J. Markiewicz <[email protected]> | ||
Chris Markiewicz <[email protected]> Christopher J. Markiewicz <[email protected]> | ||
Chris Markiewicz <[email protected]> Chris Johnson <[email protected]> | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
#!python | ||
# emacs: -*- mode: python-mode; py-indent-offset: 4; indent-tabs-mode: nil -*- | ||
# vi: set ft=python sts=4 ts=4 sw=4 et: | ||
### ### ### ### ### ### ### ### ### ### ### ### ### ### ### ### ### ### ### ## | ||
# | ||
# See COPYING file distributed along with the NiBabel package for the | ||
# copyright and license terms. | ||
# | ||
### ### ### ### ### ### ### ### ### ### ### ### ### ### ### ### ### ### ### ## | ||
""" | ||
Quick diff summary for a set of neuroimaging files | ||
""" | ||
|
||
from nibabel.cmdline.diff import main | ||
|
||
if __name__ == '__main__': | ||
main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,4 @@ | |
-r requirements.txt | ||
nose | ||
mock | ||
hypothesis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the appearance of my name, but you could add me and Chris with abbreviations (YOH, CC?) as "Other contributors" in the section above where you introduce them in general. I think we will keep appearing here from time to time ;)