MAINT: Import abstract classes from collections.abc for Python 3.8 compatibility#711
Merged
effigies merged 3 commits intonipy:masterfrom Jan 14, 2019
Merged
MAINT: Import abstract classes from collections.abc for Python 3.8 compatibility#711effigies merged 3 commits intonipy:masterfrom
effigies merged 3 commits intonipy:masterfrom
Conversation
effigies
reviewed
Jan 13, 2019
Member
effigies
left a comment
There was a problem hiding this comment.
Thanks, this looks good. Very small suggestion.
Co-Authored-By: larsoner <larson.eric.d@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
==========================================
+ Coverage 88.83% 88.84% +<.01%
==========================================
Files 93 93
Lines 11460 11464 +4
Branches 1896 1896
==========================================
+ Hits 10181 10185 +4
Misses 937 937
Partials 342 342
Continue to review full report at Codecov.
|
Co-Authored-By: larsoner <larson.eric.d@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes imports that cause: