Skip to content

CI: Run coverage on as many tests as possible #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 12, 2019
Merged

Conversation

effigies
Copy link
Member

@effigies effigies commented Feb 7, 2019

With the number of catches we have for optional dependencies (and possibly still some Python version checks), and the tests in place to make sure they work, it is a little odd to check the coverage and see them untried. This should help identify, at a glance, which of these checks are genuinely missed.

coverage.py has no dependencies, so installing it in all cases does not complicate our minimal test cases.

@coveralls
Copy link

coveralls commented Feb 7, 2019

Coverage Status

Coverage increased (+0.07%) to 91.908% when pulling bc0f6e7 on ci/max_coverage into 7927c2d on master.

@codecov-io
Copy link

codecov-io commented Feb 8, 2019

Codecov Report

Merging #722 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
+ Coverage    89.1%   89.39%   +0.28%     
==========================================
  Files          93       93              
  Lines       11469    11476       +7     
  Branches     1992     1992              
==========================================
+ Hits        10220    10259      +39     
+ Misses        908      882      -26     
+ Partials      341      335       -6
Impacted Files Coverage Δ
nibabel/streamlines/array_sequence.py 100% <100%> (ø) ⬆️
nibabel/nifti1.py 91.52% <0%> (+0.3%) ⬆️
nibabel/dft.py 81.09% <0%> (+0.6%) ⬆️
nibabel/viewers.py 96.06% <0%> (+0.65%) ⬆️
nibabel/__init__.py 93.61% <0%> (+2.12%) ⬆️
nibabel/casting.py 87.28% <0%> (+2.54%) ⬆️
nibabel/openers.py 81.45% <0%> (+3.22%) ⬆️
nibabel/pkg_info.py 79.31% <0%> (+13.79%) ⬆️
nibabel/environment.py 95% <0%> (+20%) ⬆️
nibabel/pydicom_compat.py 100% <0%> (+35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7927c2d...bc0f6e7. Read the comment docs.

@effigies effigies merged commit ad0b13f into master Feb 12, 2019
@effigies effigies deleted the ci/max_coverage branch February 12, 2019 02:15
@effigies effigies added this to the 2.4.0 milestone Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants