CI: Run coverage on as many tests as possible#722
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
==========================================
+ Coverage 89.1% 89.39% +0.28%
==========================================
Files 93 93
Lines 11469 11476 +7
Branches 1992 1992
==========================================
+ Hits 10220 10259 +39
+ Misses 908 882 -26
+ Partials 341 335 -6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the number of catches we have for optional dependencies (and possibly still some Python version checks), and the tests in place to make sure they work, it is a little odd to check the coverage and see them untried. This should help identify, at a glance, which of these checks are genuinely missed.
coverage.py has no dependencies, so installing it in all cases does not complicate our minimal test cases.