Conversation
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
==========================================
+ Coverage 88.36% 89.54% +1.17%
==========================================
Files 188 93 -95
Lines 23998 11470 -12528
Branches 4258 1991 -2267
==========================================
- Hits 21207 10271 -10936
+ Misses 2103 859 -1244
+ Partials 688 340 -348
Continue to review full report at Codecov.
|
effigies
commented
Mar 19, 2019
effigies
commented
Apr 1, 2019
| "orcid": "0000-0001-6313-0580" | ||
| }, | ||
| { | ||
| "name": "Cieslak, Matt" |
Member
Author
There was a problem hiding this comment.
@mattcieslak Let me know if you have another name you prefer for publications, your affiliation, and your ORCID. (Sorry if you've given this to me in another package, but I couldn't find it from a quick look.)
Contributor
There was a problem hiding this comment.
Here it is @effigies
{
"name": "Cieslak, Matthew",
"affiliation": "Department of Neuropsychiatry, University of Pennsylvania",
"orcid": "0000-0002-1931-4734"
},
Member
Author
There was a problem hiding this comment.
Gah, just a few minutes too late! I'll have it in for the 2.4.1 release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for nibabel release 2.4.0, targeting Monday, 25 March 2019.
The 2.4.0 milestone has been added for issues that should be addressed before a minor version release or pull requests that should be merged or deferred. Please add any issues or pull requests that need attention to the milestone or comment in this thread.
Issues/PRs that need to be addressed, merged or postponed
This is a partial list of the open PRs, based on my judgment of how close they are to ready or how likely the submitter is to still be active. If you think I've missed some, please let me know. I will try to update all of these issues/PRs, even if they don't get resolved this round.
Submitters: I would appreciate if all PRs could be merged or rebased with the current master.
Additional help pushing forward these issues or reviewing PRs would be very welcome.
I will merge #736 before releasing in the event of no reviews.
Pre-release checklist
doc/source/index.rstand add any authors not yet acknowledged..mailmap fileif there are any duplicate authors listed fromgit shortlog -nse.LONG_DESCRIPTIONininfo.pyby runningmake refresh-readme.nibabel/info.py(e.g.NUMPY_MIN_VERSION) and indoc/source/installation.rstand inrequirements.txtand.travis.yml. They should at least match. Do they still hold? Make sure nibabel on travis is testing the minimum dependencies specifically.nosetests --with-doctest nibabelnibabel/info.pyto set_version_extrato''; commitI'm skipping the build-bots, as they don't seem to buy us much that isn't in the CI. @matthew-brett Please let me know if there's a good reason to keep using them.
Adapted from http://nipy.org/nibabel/devel/make_release.html#release-checklist