Skip to content

RF: Improve fallback version check, require PyPA packaging module #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

effigies
Copy link
Member

@effigies effigies commented Jan 7, 2020

This moves us fully to PEP440-compliance, and uses the packaging.version module, a carve-out of pip. Using their Version object allows us to avoid manual munging of version strings.

This is a new dependency, but a fairly lightweight one. It reintroduces six and adds pyparsing to our dependency tree. I expect six will probably disappear in a version or two, and pyparsing itself has no dependencies.

Due to the new dependency, this is proposed for 3.1.

Fixes #855.

@effigies effigies added this to the 3.1.0 milestone Jan 7, 2020
@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #856 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
- Coverage   89.67%   89.66%   -0.02%     
==========================================
  Files          96       96              
  Lines       12398    12382      -16     
  Branches     2187     2184       -3     
==========================================
- Hits        11118    11102      -16     
  Misses        935      935              
  Partials      345      345
Impacted Files Coverage Δ
nibabel/pkg_info.py 73.91% <100%> (-10.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34384cb...5389364. Read the comment docs.

@effigies
Copy link
Member Author

Anybody up for a review? Principled objections to the packaging dependency?

@effigies effigies merged commit 5877c17 into nipy:master Jan 15, 2020
@effigies effigies deleted the rf/packaging branch January 15, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_pkg_info fail
1 participant