Skip to content

DOC: Attempt to find versioneer version when building docs #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 6, 2020

Conversation

effigies
Copy link
Member

@effigies effigies commented Mar 5, 2020

Closes #869.

Start by trying to get CI to fail pre-fix. It currently is failing silently.

Edit: Also tracked down various warnings emitted during doc build. Some remain:

Running Sphinx v2.2.1
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 115 source files that are out of date
updating environment: [new config] 115 added, 0 changed, 0 removed
/System/Volumes/Data/anaconda3/envs/nibabel-dev/lib/python3.7/importlib/__init__.py:127: UserWarning: The DICOM readers are highly experimental, unstable, and only work for Siemens time-series at the moment                                                                        
Please use with caution.  We would be grateful for your help in improving them
  return _bootstrap._gcd_import(name[level:], package, level)
reading sources... [100%] tutorials                                                                                                                                                                                                                                                   
/Users/markiewicz/Projects/nibabel/nibabel/cifti2/__init__.py:docstring of nibabel.cifti2.rst:5: WARNING: autosummary: stub file not found 'nibabel.cifti2.cifti2'. Check your autosummary_generate setting.
/Users/markiewicz/Projects/nibabel/nibabel/cifti2/__init__.py:docstring of nibabel.cifti2.rst:5: WARNING: autosummary: stub file not found 'nibabel.cifti2.cifti2_axes'. Check your autosummary_generate setting.
/Users/markiewicz/Projects/nibabel/nibabel/gifti/__init__.py:docstring of nibabel.gifti.rst:5: WARNING: autosummary: stub file not found 'nibabel.gifti.giftiio'. Check your autosummary_generate setting.
/Users/markiewicz/Projects/nibabel/nibabel/gifti/__init__.py:docstring of nibabel.gifti.rst:5: WARNING: autosummary: stub file not found 'nibabel.gifti.gifti'. Check your autosummary_generate setting.
/Users/markiewicz/Projects/nibabel/nibabel/nicom/__init__.py:docstring of nibabel.nicom.rst:5: WARNING: autosummary: stub file not found 'nibabel.nicom.csareader'. Check your autosummary_generate setting.
/Users/markiewicz/Projects/nibabel/nibabel/nicom/__init__.py:docstring of nibabel.nicom.rst:5: WARNING: autosummary: stub file not found 'nibabel.nicom.dicomreaders'. Check your autosummary_generate setting.
/Users/markiewicz/Projects/nibabel/nibabel/nicom/__init__.py:docstring of nibabel.nicom.rst:5: WARNING: autosummary: stub file not found 'nibabel.nicom.dicomwrappers'. Check your autosummary_generate setting.
/Users/markiewicz/Projects/nibabel/nibabel/nicom/__init__.py:docstring of nibabel.nicom.rst:5: WARNING: autosummary: stub file not found 'nibabel.nicom.dwiparams'. Check your autosummary_generate setting.
/Users/markiewicz/Projects/nibabel/nibabel/nicom/__init__.py:docstring of nibabel.nicom.rst:5: WARNING: autosummary: stub file not found 'nibabel.nicom.structreader'. Check your autosummary_generate setting.
looking for now-outdated files... none found
pickling environment... done
checking consistency... /Users/markiewicz/Projects/nibabel/doc/source/devel/bv_formats.rst: WARNING: document isn't included in any toctree
/Users/markiewicz/Projects/nibabel/doc/source/devel/data_pkg_discuss.rst: WARNING: document isn't included in any toctree
/Users/markiewicz/Projects/nibabel/doc/source/devel/data_pkg_uses.rst: WARNING: document isn't included in any toctree
/Users/markiewicz/Projects/nibabel/doc/source/devel/image_design.rst: WARNING: document isn't included in any toctree
/Users/markiewicz/Projects/nibabel/doc/source/devel/scaling.rst: WARNING: document isn't included in any toctree
/Users/markiewicz/Projects/nibabel/doc/source/installing_data.rst: WARNING: document isn't included in any toctree
/Users/markiewicz/Projects/nibabel/doc/source/notebooks/index.rst: WARNING: document isn't included in any toctree
/Users/markiewicz/Projects/nibabel/doc/source/old/ioimplementation.rst: WARNING: document isn't included in any toctree
done
preparing documents... done
/System/Volumes/Data/anaconda3/envs/nibabel-dev/lib/python3.7/site-packages/sphinx/transforms/post_transforms/compat.py:45: RemovedInSphinx30Warning: math node for Sphinx was replaced by docutils'. Please use ``docutils.nodes.math`` instead.                                     
  RemovedInSphinx30Warning)

@effigies effigies added this to the 3.0.2 milestone Mar 5, 2020
@effigies effigies force-pushed the doc/update_config branch from d01f1e6 to 03c6c31 Compare March 5, 2020 03:26
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #894 into maint/3.0.x will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           maint/3.0.x     #894      +/-   ##
===============================================
- Coverage         89.7%   89.62%   -0.09%     
===============================================
  Files               96       96              
  Lines            12418    12418              
  Branches          2187     2187              
===============================================
- Hits             11140    11130      -10     
- Misses             933      939       +6     
- Partials           345      349       +4
Impacted Files Coverage Δ
nibabel/streamlines/tractogram.py 99.67% <ø> (ø) ⬆️
nibabel/cifti2/cifti2.py 96.68% <ø> (ø) ⬆️
nibabel/cifti2/cifti2_axes.py 98.34% <ø> (ø) ⬆️
nibabel/cifti2/__init__.py 100% <ø> (ø) ⬆️
nibabel/streamlines/tck.py 99.46% <ø> (ø) ⬆️
nibabel/affines.py 100% <ø> (ø) ⬆️
nibabel/nifti1.py 91.21% <ø> (-0.31%) ⬇️
nibabel/brikhead.py 97.54% <ø> (ø) ⬆️
nibabel/gifti/gifti.py 95.42% <ø> (ø) ⬆️
nibabel/environment.py 75% <0%> (-20%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6967461...4ac9821. Read the comment docs.

@effigies
Copy link
Member Author

effigies commented Mar 5, 2020

I think this should be pretty uncontroversial. A review of the remaining errors would be appreciated.

  • @matthew-brett I'm guessing /System/Volumes/Data/anaconda3/envs/nibabel-dev/lib/python3.7/site-packages/sphinx/transforms/post_transforms/compat.py:45: RemovedInSphinx30Warning: math node for Sphinx was replaced by docutils'. Please use ``docutils.nodes.math`` instead. RemovedInSphinx30Warning) is texext-related, but switching to docutils.nodes.math in a fork of texext didn't resolve the warning. Any thoughts?

  • The autosummary errors don't seem to be resolvable without changing the docs. My guess is we can get around this by using more bog-standard apidoc, but I don't have the energy to tackle that at the moment.

  • Should any of the orphaned files be added to some ToC? If not, I think we can add .. orphan: or similar directive to clear the warning.

@matthew-brett
Copy link
Member

I am not sure where that warning comes from - but I'm getting the same warning in daily testing of texext : https://travis-ci.org/matthew-brett/texext/jobs/658565402#L441

@matthew-brett
Copy link
Member

I just uploaded another release of texext, with a related fix from a while ago - does it help?

@effigies
Copy link
Member Author

effigies commented Mar 5, 2020

Nope. Still getting the warning. Looks like they've removed the compatibility in master. I can try upgrading sphinx and seeing if that breaks something informative.

@effigies
Copy link
Member Author

effigies commented Mar 6, 2020

Okay. This is an improvement and resolve an issue blocking a bug-fix release. Additional improvements can come later.

@effigies effigies merged commit ee19d7a into nipy:maint/3.0.x Mar 6, 2020
@effigies effigies deleted the doc/update_config branch March 6, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants