RF: Use np.flip instead of flip_axis #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package requires numpy >= 1.13, np.flip was added in 1.12 Add deprecation (from 3.2 until 5.0) + deprecation test Remove flip_axis test
Codecov Report
@@ Coverage Diff @@
## master #916 +/- ##
==========================================
- Coverage 91.81% 91.73% -0.09%
==========================================
Files 97 97
Lines 12359 12357 -2
Branches 2177 2177
==========================================
- Hits 11348 11336 -12
- Misses 678 684 +6
- Partials 333 337 +4
Continue to review full report at Codecov.
|
In order to pass the CI...
effigies
reviewed
May 25, 2020
| @@ -230,20 +230,21 @@ def inv_ornt_aff(ornt, shape): | |||
|
|
|||
|
|
|||
| @deprecate_with_version('orientation_affine deprecated. ' | |||
| 'Please use inv_ornt_aff instead' | |||
| 'Please use inv_ornt_aff instead.', | |||
There was a problem hiding this comment.
Oof. Good catch. I guess bumping back to 4.0 is the right thing to do, though hopefully nobody is depending on it, still.
Co-authored-by: Chris Markiewicz <[email protected]>
effigies
reviewed
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package requires numpy >= 1.13, np.flip was added in 1.12
Add deprecation (from 3.2 until 5.0) + deprecation test
Remove flip_axis test