Skip to content

FIX: Set CIFTI-2 dimensions in the last three entries of dim #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2020

Conversation

effigies
Copy link
Member

@effigies effigies commented Jul 2, 2020

Builds on and supersedes #929.

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #930 into maint/3.1.x will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           maint/3.1.x     #930      +/-   ##
===============================================
- Coverage        91.86%   91.77%   -0.09%     
===============================================
  Files               97       97              
  Lines            12360    12360              
  Branches          2177     2177              
===============================================
- Hits             11354    11344      -10     
- Misses             675      681       +6     
- Partials           331      335       +4     
Impacted Files Coverage Δ
nibabel/cifti2/cifti2.py 96.67% <100.00%> (ø)
nibabel/environment.py 75.00% <0.00%> (-20.00%) ⬇️
nibabel/casting.py 85.28% <0.00%> (-0.87%) ⬇️
nibabel/dft.py 80.36% <0.00%> (-0.62%) ⬇️
nibabel/nifti1.py 92.12% <0.00%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f23b279...3667373. Read the comment docs.

Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Chris

@effigies effigies merged commit 97a0467 into nipy:maint/3.1.x Jul 2, 2020
@effigies effigies deleted the fix/cifti_shape branch July 2, 2020 18:09
@effigies
Copy link
Member Author

effigies commented Jul 2, 2020

Thanks for the review.

@effigies effigies added this to the 3.2.0 milestone Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants