Skip to content

MRG: edits of PR #896 #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 12, 2020
Merged

MRG: edits of PR #896 #935

merged 4 commits into from
Jul 12, 2020

Conversation

matthew-brett
Copy link
Member

Closes #896 by applying edits in discussion there.

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #935 into master will increase coverage by 0.13%.
The diff coverage is 89.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
+ Coverage   91.70%   91.84%   +0.13%     
==========================================
  Files          96       97       +1     
  Lines       12311    12423     +112     
  Branches     2173     2190      +17     
==========================================
+ Hits        11290    11410     +120     
+ Misses        684      678       -6     
+ Partials      337      335       -2     
Impacted Files Coverage Δ
nibabel/nicom/ascconv.py 89.87% <89.87%> (ø)
nibabel/data.py 86.99% <0.00%> (ø)
nibabel/ecat.py 88.07% <0.00%> (ø)
nibabel/info.py 100.00% <0.00%> (ø)
nibabel/funcs.py 80.28% <0.00%> (ø)
nibabel/optpkg.py 97.05% <0.00%> (ø)
nibabel/parrec.py 92.50% <0.00%> (ø)
nibabel/affines.py 100.00% <0.00%> (ø)
nibabel/analyze.py 98.52% <0.00%> (ø)
nibabel/viewers.py 96.14% <0.00%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65d5fc6...a4ca273. Read the comment docs.

More explicit stuff in docstrings.  Use generic OrderedDict rather than
externals copy.
@effigies
Copy link
Member

Looks good. Thanks!

@effigies effigies merged commit 559d4e0 into nipy:master Jul 12, 2020
@effigies effigies added this to the 3.2.0 milestone Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants