-
Notifications
You must be signed in to change notification settings - Fork 59
Support using container entrypoints for shell tasks #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tclose
wants to merge
8
commits into
main
Choose a base branch
from
container-entrypoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
===========================================
- Coverage 88.76% 64.11% -24.66%
===========================================
Files 84 84
Lines 17890 17907 +17
Branches 3483 1556 -1927
===========================================
- Hits 15880 11481 -4399
- Misses 1640 6024 +4384
- Partials 370 402 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dd382ca
to
d7a9b2a
Compare
…handling performed in Environment.execute
6f08e7b
to
38a1db8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Summary
When executing shell commands in Docker/Singularity containers, permit setting
executable
to None in order to use the entrypoint of the container.Checklist