fix(config): resolve model defaults per agent provider - #22
Merged
Conversation
The model input defaults were hard-coded Claude ids in action.yml, so a
Codex run with no explicit model override sent a Claude model name to the
Codex SDK and failed with a 400 ("model not supported when using Codex
with a ChatGPT account").
Blank the action.yml model defaults and resolve a provider-aware default
in parseConfig: claude-opus-4-8[1m] (claude-sonnet-4-6 for triage) for
claude, gpt-5.5 for every codex stage. An explicit model input still wins.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Shopfloor agent review: clean across 4/4 reviewers.
- No coding-standard or agent-convention violations: the only convention file is CLAUDE.md, the dist bundle is included/rebuilt as required, and the diff introduces nothing that contradicts documented commands, file-placement, package-manager, or formatting rules.
- Provider-aware model-default substitution is logically correct; agent_provider is enum-constrained so the DEFAULT_MODELS lookup is always defined, empty inputs fall through to defaults, and explicit values override.
- Model-default resolution refactor only; no exploitable security patterns introduced.
- Provider-aware model-default change is well-structured with explanatory comments and matching tests; no maintainability smells worth flagging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Codex runs with no explicit model override failed every stage with a 400:
The model input defaults were hard-coded Claude ids in
action.yml, which the Actions runtime injects before our code runs. So even when a consumer setagent_provider: codexand left the model inputs unset, a Claude model id reached the Codex SDK.Fix
action.yml: blank all eight*_modeldefaults (default: "").src/config/inputs.ts:parseConfigresolves an empty model input to a provider-aware default via aDEFAULT_MODELStable:claude-opus-4-8[1m]for spec/plan/implement/review,claude-sonnet-4-6for triage (existing cheaper triage tier preserved; opus bumped 4-7 → 4-8).gpt-5.5for every stage.Notes
2.0.2;dist/index.cjsrebuilt.parseConfigtests for claude defaults, codex defaults, and explicit-override precedence. Full suite: 281 passing.