initial prep_NISAR

[ehavazli]

This PR includes a new notebook to prepare NISAR data to run through ATBD methods. Currently only ionospheric correction layer is extracted. A script for extracting layers from NISAR data is obtained from ADT and included here with it's own history. Another PR will follow for the automated extraction and loading of troposphere and solid earth tides layers.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[rzinke]

Worked for me. Properly set up MintPy/inputs files as expected.

[katia-tymofyeyeva]

Please don't merge - the notebook does not work with the rest of the workflow and real NISAR data. Several changes have to be made, including creating the mintpy configuration file, creating a mask file and others. The rest of the workflow also needs some adaptations to work with NISAR data. I am making the changes and will commit as soon as they are ready. Thanks! -Katia

[ehavazli]

@katia-tymofyeyeva

• Can you please be more specific what didn't work for you? I tested again from scratch and everything worked as intended.
• I added the MintPy configuration file generation.
• Mask files are generated in later stages from the data (e.g., coherence or connected component based) according to user needs. I don't think it is a good idea to mask the data at this stage.
• Please specify the other missing files.
• This PR has been open awaiting review for a long time. The adaptations for the rest of the workflow was not initially part of this PR so I don't think there is a need to discuss them here.

I added my_sites.txt file to this PR so you can test with the sample data and let me know if you find any issues.
Thank you!

[katia-tymofyeyeva]

Hi Emre,

We discussed on Slack in detail all the things that didn't work when trying to run this prep notebook with the rest of the workflow: the lack of MintPy configuration file, the reversed date notation, and a few other issues. I mentioned also that I was working on updates and asked that you wait for me to make commits. Thank you for the update, but in the future, please coordinate on Slack or over email before you make changes, so that we don't work at cross purposes and neither of us wastes their time.

I will now test your new version with real NISAR data and all three of the "method" workflows, and I will get back to you. If you are going to make further changes, please let me know.

Thanks.
Katia

[ehavazli]

@katia-tymofyeyeva

I think there has been a confusion. This is only the prep_NISAR notebook and I added the configuration file generation. The reversed date issue is part of and fixed in the MintPy PR (nisar-solid/MintPy#4).
The changes and issues with the methods notebooks should go into a separate PR so we can track those changes correctly.

Let me know how you would like to proceed.

Thanks.
Emre

[katia-tymofyeyeva]

Hi Emre,

Understood. For the prep_NISAR notebook alone, there are still a couple more changes that need to be made:

• Extracting the mask into a mask file that can later be read by the method notebooks
• Testing the full workflow to make sure that the products that come out of this notebook are compatible with what is expected by the method notebooks. If not, making the corresponding changes to prep_NISAR (and possibly to the corresponding mintpy module). If, as part of this process, we discover that we need to make significant changes to the method notebooks, we can make the decision how to proceed.

Until we finish with this process, the creation of the prep_NISAR notebook, and therefore this PR, is not complete.

I suggest we discuss the details on Slack.

Thank you for your support!
Katia

Requested changes were made.

[katia-tymofyeyeva]

Merging, for now, more updates to come.