Allow splitting only within grid bounds - #73
Merged
Conversation
thomas-fred
reviewed
Oct 28, 2025
thomas-fred
reviewed
Oct 28, 2025
|
Perhaps worth adding a test where a segment is co-linear with some part of a grid. Also in the case of co-linear with a grid edge (in the bounded case). |
|
Nothing else catches my eye |
tomalrussell
force-pushed
the
fix/47-splits-outside-grid
branch
from
August 18, 2026 15:26
aff1e0c to
021e643
Compare
- Horizontal/vertical segments - Various directions - Could maybe reuse a linesCross check to simplify further? - Add docstring noting that it's a test for whether a line-segment intersects a rectangular extent (i.e. "within" is okay, as subset of "intersects")
Member
Author
Added some more tests, including co-linear with bounds. Just looking at the CI, needs linting but getting close! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to close #47