Skip to content

fix: use module condition and main fields for bundling #3886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pi0 merged 3 commits into from
Dec 18, 2025
Merged

fix: use module condition and main fields for bundling #3886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85a16ef
fix: use `module` condition and main fields for bundling
pi0 Dec 18, 2025
faeab8e
Update src/config/resolvers/export-conditions.ts
pi0 Dec 18, 2025
96d4f19
up
pi0 Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/build/rolldown/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export const getRolldownConfig = (nitro: Nitro): RolldownOptions => {
resolve: {
alias: base.aliases,
extensions: base.extensions,
mainFields: ["main"], // "module" is intentionally not supported because of externals
conditionNames: nitro.options.exportConditions,
},
transform: {
Expand Down
2 changes: 0 additions & 2 deletions src/build/rollup/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ export const getRollupConfig = (nitro: Nitro): RollupConfig => {
extensions: base.extensions,
preferBuiltins: !!nitro.options.node,
rootDir: nitro.options.rootDir,
// 'module' is intentionally not supported because of externals
mainFields: ["main"],
exportConditions: nitro.options.exportConditions,
}),
(commonjs as unknown as typeof commonjs.default)({
Expand Down
4 changes: 2 additions & 2 deletions src/build/vite/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export function createNitroEnvironment(
: true, // production build is standalone
conditions: ctx.nitro!.options.exportConditions,
externalConditions: ctx.nitro!.options.exportConditions?.filter(
(c) => !/browser|wasm/.test(c)
(c) => !/browser|wasm|module/.test(c)
Comment thread
pi0 marked this conversation as resolved.
),
},
define: {
Expand Down Expand Up @@ -77,7 +77,7 @@ export function createServiceEnvironment(
resolve: {
conditions: ctx.nitro!.options.exportConditions,
externalConditions: ctx.nitro!.options.exportConditions?.filter(
(c) => !/browser|wasm/.test(c)
(c) => !/browser|wasm|module/.test(c)
),
},
dev: {
Expand Down
3 changes: 2 additions & 1 deletion src/config/resolvers/export-conditions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ function _resolveExportConditions(
}

// 5. Add default conditions
resolvedConditions.push("import", "default");
// "module" is NOT A STANDARD CONDITION but widely used in the ecosystem adding helps with compatibility
resolvedConditions.push("import", "default", "module");
Comment thread
pi0 marked this conversation as resolved.

// 6. Auto detect bun and deno (builder)
if ("Bun" in globalThis) {
Expand Down
1 change: 0 additions & 1 deletion src/presets/standard/preset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ const standard = defineNitroPreset(
{
entry: "./standard/runtime/server",
serveStatic: false,
exportConditions: ["import", "default"],
output: {
publicDir: "{{ output.dir }}/public/{{ baseURL }}",
},
Expand Down
Loading