Skip to content

fix: avoid adding extra additional export conditions #4029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pi0 merged 3 commits into from
Feb 12, 2026
Merged

fix: avoid adding extra additional export conditions #4029

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e180ac0
fix: avoid adding extra export conditions
pi0 Feb 12, 2026
f8f7f8f
update comment
pi0 Feb 12, 2026
4cfa31c
update
pi0 Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 9 additions & 25 deletions src/config/resolvers/export-conditions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,48 +12,32 @@ function _resolveExportConditions(
conditions: string[],
opts: { dev: boolean; node: boolean; wasm?: boolean }
) {
const negated = new Set(conditions.filter((c) => c.startsWith("!")).map((c) => c.slice(1)));

const resolvedConditions: string[] = [];

// 1. Add dev or production
resolvedConditions.push(opts.dev ? "development" : "production");

// 2. Add user specified conditions
resolvedConditions.push(...conditions);

// 3. Add runtime conditions (node or web)
if (opts.node) {
resolvedConditions.push("node");
} else {
// https://runtime-keys.proposal.wintercg.org/
resolvedConditions.push(
"wintercg",
"worker",
"web",
"browser",
"workerd",
"edge-light",
"netlify",
"edge-routine",
"deno"
);
}
resolvedConditions.push(...conditions.filter((c) => !c.startsWith("!")));

// 4. Add unwasm conditions
// 3. Add unwasm conditions
if (opts.wasm) {
resolvedConditions.push("wasm", "unwasm");
}

// 5. Add default conditions
// 4. Add default conditions
// "module" is NOT A STANDARD CONDITION but widely used in the ecosystem adding helps with compatibility
resolvedConditions.push("import", "default", "module");
resolvedConditions.push("module");
Comment thread
pi0 marked this conversation as resolved.
Outdated

// 6. Auto detect bun and deno (builder)
// 5. Auto detect bun and deno (builder)
if ("Bun" in globalThis) {
resolvedConditions.push("bun");
} else if ("Deno" in globalThis) {
resolvedConditions.push("deno");
}
Comment thread
pi0 marked this conversation as resolved.

// Dedup with preserving order
return resolvedConditions.filter((c, i) => resolvedConditions.indexOf(c) === i);
// 6. Dedup and remove negated conditions
return [...new Set(resolvedConditions)].filter((c) => !negated.has(c));
}
Loading