Skip to content

build: re-export FastResponse and srvx types #4499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schplitt wants to merge 4 commits into
base: main
Choose a base branch
from
Open

build: re-export FastResponse and srvx types #4499

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5d4cf9
feat: add srvx module re-export
schplitt Jul 30, 2026
a1209b6
fix: adjust exports to be non breaking
schplitt Jul 30, 2026
dbb3ad8
fix: remove ServerRequest type export from `nitro` subpath
schplitt Jul 30, 2026
d05d202
fix: remove duplicate exports
schplitt Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/srvx.d.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from "srvx";
1 change: 1 addition & 0 deletions lib/srvx.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from "srvx";
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"./context": "./dist/runtime/context.mjs",
"./database": "./dist/runtime/database.mjs",
"./h3": "./lib/h3.mjs",
"./srvx": "./lib/srvx.mjs",

@pi0 pi0 Jul 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exporting all can be risky against breaking change surface (srvx 0.12 to 0.13 could drop some for example), instead we can simply export FastResponse from main nitro subpath

@schplitt schplitt Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. I know I needed FastURL and ServerRequest aswell as the types for those + ServerRequestContext, ServerRuntimeContext in the past

These can go under the nitro subpath aswell?

@pi0 pi0 Jul 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have nitro/types subpath for types. Not sure about ServerRequestContext i guess it needs explicit declaration for srvx to extend

@schplitt schplitt Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the exports :)

"./meta": "./dist/runtime/meta.mjs",
"./package.json": "./package.json",
"./runtime-config": "./dist/runtime/runtime-config.mjs",
Expand Down