Skip to content

chore: add vite test script for ecosystem ci - #4510

Open
oneminch wants to merge 1 commit into
nitrojs:mainfrom
oneminch:chore/vite-test-script
Open

chore: add vite test script for ecosystem ci#4510
oneminch wants to merge 1 commit into
nitrojs:mainfrom
oneminch:chore/vite-test-script

Conversation

@oneminch

@oneminch oneminch commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

Follow up to vitejs/vite-ecosystem-ci#505

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds a Vite test script to package.json following https://github.com/vitejs/vite-ecosystem-ci/pull/505/changes#r3733642821, so that it can be used in the Vite Ecosystem CI more flexibly.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@oneminch
oneminch requested a review from pi0 as a code owner August 7, 2026 18:39
@vercel

vercel Bot commented Aug 7, 2026

Copy link
Copy Markdown

@oneminch is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 36073b20-ba53-46de-82c8-d4b45d4b4433

📥 Commits

Reviewing files that changed from the base of the PR and between 52abde8 and d4478c3.

📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

The package scripts now include test:vite, which runs the Vitest suite in test/vite.

Changes

Vite test execution

Layer / File(s) Summary
Add Vite test command
package.json
Adds test:vite to run pnpm vitest run test/vite.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title uses the conventional commits format and accurately describes the added Vite test script.
Description check ✅ Passed The description clearly explains the package script addition and its use in Vite Ecosystem CI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Aug 7, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/nitro@4510

commit: d4478c3

oneminch added a commit to oneminch/oss-vite-ecosystem-ci that referenced this pull request Aug 8, 2026
- Follow up to vitejs@076c1b9#r3733642821
- Replaces hard-coded test script with specific test directory
- Requires nitrojs/nitro#4510 to be merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant