chore: Lint pinned SHAs in CI - #4514
Conversation
Signed-off-by: ysknsid25 <kengo071225@gmail.com>
|
@ysknsid25 is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe PR adds a ChangesCI SHA verification
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/pinact.yml (1)
17-18: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winEnable version-comment verification.
fix: "false"checks that action references are pinned, butverifyremains disabled. A full-length SHA can still have a false# v...annotation or identify a commit from a fork. If version annotations are part of the policy, addverify: "true".Proposed change
- with: { skip_push: "true", fix: "false" } + with: + skip_push: "true" + fix: "false" + verify: "true"The pinned
pinact-actionrelease supports this input, and its bundled pinact version recommends version-comment verification in CI. (github.com)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/pinact.yml around lines 17 - 18, Update the pinact-action configuration to add the supported verify input set to true, while preserving the existing skip_push and fix settings.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/pinact.yml:
- Around line 3-4: Update the workflow trigger from pull_request to
pull_request_target and ensure the validator executes the trusted base-branch
workflow and configuration rather than any pull-request-modified files. Do not
load pinact configuration or workflow logic from the checked-out pull request;
keep validation behavior controlled by repository content outside the
contributor’s changes.
---
Nitpick comments:
In @.github/workflows/pinact.yml:
- Around line 17-18: Update the pinact-action configuration to add the supported
verify input set to true, while preserving the existing skip_push and fix
settings.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d2add7d5-2a60-4a5c-993b-da1c6d866bc5
📒 Files selected for processing (1)
.github/workflows/pinact.yml
🔗 Linked issue
resolves: #4513
❓ Type of change
📚 Description
📝 Checklist