Tim's refactor of track0 sectors for os9 format #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
strickyak
commented
May 27, 2025
strickyak
commented
It should not be different from the sector size on other tracks. Also a unit test that breaks when the bug exists. FIXES #28
This simplifies how the sectorsTrack0 variable is used, giving it an "unset" value of 0. It moves a test that forks the "os9 format" command into a new file unittest/os9commandtest.c Fixes the order of libraries, as needed in automated testing. This PR was originally #31 but the fundamental bug fix was made in #29 so it has been adapted.
tlindner
approved these changes
May 29, 2025
Member
|
I really appreciate you taking care of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.