fix: proper check for setting /sbin when changing populateBin from true to false - #1010
Merged
Conversation
Member
|
Thanks! |
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-1010-to-release-25.05 origin/release-25.05
cd .worktree/backport-1010-to-release-25.05
git switch --create backport-1010-to-release-25.05
git cherry-pick -x 146e7c5e8e50ea9be30f7a85e7090c595a28ff06 e58c9f4b3233d63abe4dfc4f7d69704900428348 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.11
git worktree add -d .worktree/backport-1010-to-release-25.11 origin/release-25.11
cd .worktree/backport-1010-to-release-25.11
git switch --create backport-1010-to-release-25.11
git cherry-pick -x 146e7c5e8e50ea9be30f7a85e7090c595a28ff06 e58c9f4b3233d63abe4dfc4f7d69704900428348 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1009
The bug 👿 introduced by https://github.com/nix-community/NixOS-WSL/pull/666/changes
If populateBin is false (i.e. when services.envfs enabled for nixos) the check verifies if the
/sbinis not folder, but if the system was built before without envfs the/sbinwill be populated as symlink to/bin.After enabling envfs the check will fail because the symlink to dir is also a dir, so the sbin was always pointing to the empty bin managed by envfs.
The fix verifies that the
/sbinis recreated if it's a symlink or not directory.Verified on both latest bare nixos-wsl distro and my local setup that was previously bricking after every attempt to enable envfs.