feat(rust-crane): add testFlagsExtra to interface #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Schaaf <[email protected]>
snpschaaf
force-pushed
the
rust-crane-testFlagsExtra
branch
from
abf9e89 to
80ab9ca
Compare
snpschaaf
commented
Mar 14, 2025
| testFlagsExtra = { | ||
| type = t.str; | ||
| description = "additional flags to be passed in the cargoTestCommand invocation"; | ||
| default = "--no-run"; |
There was a problem hiding this comment.
TODO:FIXME: this default should not be streamlined.
crane expect a string here. Without default everyone needs to set it. With some default some crane default would be overwritten. Make this interface optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extended the interface to access cranes setting
cargoTestExtraArgs. Users can do so now viatestFlagsExtra(named liketestFlagsdoes forcargoTestFlags).