feat(syncthing): impl encryptionPasswordFile #7128
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Syncthing allows setting a password for specific devices a specific folder is shared with. Files are encrypted before being send to this device. The password can be set using the API by setting the
encryptionPassword
property of the given device in a folder config.Previously it was not possible to use this functionality of Syncthing with this Home Manager module, because the the devices attribute of a configured folder only accepted strings. The module than created a device item as expected by the Syncthing API, but only set the
deviceID
attribute of this item, but neglected the optionalencryptionPassword
attribute.The changes of this PR enable the usage of encrypted folder sharing, by adjusting the handling of configured folders. The items of the
devices
list of a folder config may now be attribute sets instead of strings. While strings are handled in the same way as previously, the attribute sets must contain thedeviceID
attribute may additionally contain anencryptionPasswordFile
attribute, whose value must be a path to a file, whose content will be used as the value for theencryptionPassword
attribute send to Syncthing.Checklist
Change is backwards compatible.
Code formatted with
nix fmt
ornix-shell -p treefmt nixfmt-rfc-style keep-sorted --run treefmt
.Code tested through
nix-shell --pure tests -A run.all
or
nix build --reference-lock-file flake.lock ./tests#test-all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@rycee