Skip to content

way-displays: systemdTarget is Requisite #7142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mightyiam
Copy link
Contributor

@mightyiam mightyiam commented May 27, 2025

Description

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt-rfc-style keep-sorted --run treefmt.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@jolars

@mightyiam mightyiam marked this pull request as ready for review May 27, 2025 15:49
@khaneliman
Copy link
Collaborator

Haven't seen this used really, but reading the systemd documentation... it sounds like the difference between Requires and Requisite is basically whether or not the unit will try and launch the dependency? ie: way-displays depends on the systemdTarget but won't attempt to launch that target when defined as a requisite.

@mightyiam
Copy link
Contributor Author

but won't attempt to launch that target when defined as a requisite.

That's what I'm getting as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants